faster datatables with estimated totals #8603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bffb69b to
765a83d
Compare
|
@kowh-ai I've added "(estimated)" text to the total displayed when it was estimated in the data tables view. |
5 tasks
|
@kowh-ai tests are green, this is ready for another look |
kowh-ai
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second, complementary change for #8595
Proposed fixes:
Use estimated totals when tables are larger than 100000 rows.
Drops default unfiltered ajax call run time on an 11M row dataset from 4000ms to 150ms.
Features: