Skip to content

[Backport dev-v2.11] [#8316] Fix exception in ckan generate extension command #8477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 10, 2024

Conversation

ckanbot
Copy link

@ckanbot ckanbot commented Oct 10, 2024

This is an automated backport pull request 🏗️.

Details

Original pull request #8437 ([#8316] Fix exception in ckan generate extension command)
Original author @amercader
Target branch dev-v2.11

Please make sure that all relevant checks pass before merging it.

Fixes #8316

In our post_gen_project hook, we were dumping the cookiecutter object as
a Python object but using the `jsonify` filter. Cookicutter 2.6
introduced a new item in the context which is None by default, and this
got translated as `null` when dumping it, which is not valid Python
syntax.

I've refactored the hook a bit so it dumps the context in a bit more
safely manner.

(cherry picked from commit 665c235)
(cherry picked from commit f7342c7)
@amercader amercader merged commit 0228279 into dev-v2.11 Oct 10, 2024
5 of 6 checks passed
@amercader amercader deleted the backport-8437-to-dev-v2.11 branch October 10, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants