[#8316] Fix exception in ckan generate extension command
#8437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #8316 In our post_gen_project hook, we were dumping the cookiecutter object as a Python object but using the `jsonify` filter. Cookicutter 2.6 introduced a new item in the context which is None by default, and this got translated as `null` when dumping it, which is not valid Python syntax. I've refactored the hook a bit so it dumps the context in a bit more safely manner.
|
@wardi I pushed some changes to handle any kind of value in the cookicutter context (and fixed the keys) |
|
@wardi see also #8456 (comment) |
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8316
In our post_gen_project hook, we were dumping the cookiecutter object as a Python object but using the
jsonifyfilter. Cookicutter 2.6 introduced a new item in the context which is None by default, and this got translated asnullwhen dumping it, which is not valid Python syntax.I've refactored the hook a bit so it dumps the context in a bit more safely manner.