Compile requirements and run tests with Python 3.10 #7886
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
related to #6613 |
|
Just checked and diff --git a/requirements.in b/requirements.in
index 7cf91a137..eeab11ded 100644
--- a/requirements.in
+++ b/requirements.in
@@ -2,6 +2,7 @@
# Use pip-compile to create a requirements.txt file from this
alembic==1.12.0
Babel==2.12.1
+backports-zoneinfo==0.2.1; python_version < '3.9'
Beaker==1.12.1
bleach==6.0.0
blinker==1.6.2
diff --git a/requirements.txt b/requirements.txt
index d913217cf..b08da3d04 100644
--- a/requirements.txt
+++ b/requirements.txt
@@ -10,8 +10,10 @@ babel==2.12.1
# via
# -r requirements.in
# flask-babel
-backports-zoneinfo==0.2.1
- # via tzlocal
+backports-zoneinfo==0.2.1 ; python_version < "3.9"
+ # via
+ # -r requirements.in
+ # tzlocal
beaker==1.12.1
# via -r requirements.in
bleach==6.0.0
|
This was referenced Nov 10, 2023
|
My apologies, I don't know how I tested this but I obviously didn't do a great job, as For now I'll add them manually to |
|
Closing as implemented a consolidated approach in #7936 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current requirements were compiled using Python 3.8.
This is causing incompatibility with Python 3.10 since the compile process introduces
backports.zoneinfoas a dependency.backports.zoneinfodoes not run under Python 3.10 (https://stackoverflow.com/a/72796492)I'm re-compiling the file and also updating our CD/CI files to run tests under Python 3.10