Customize R/W datastore resource url_types #7618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
feedback from call: use configuration option that can be updated from plugins instead. Although we still need a helper for templates to check the R/W state, and I can't think of a case of a user wanting to configure this setting in their environment/ini file. 🤔 |
|
If you are going to use it in templates or somewhere else, it's justified. Initially, I got the impression, that this list of resource types is going to be used solely by this validation check. And registering a helpers function just as an extension point for a validation check doesn't sound like a good idea:) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7617
Proposed fixes:
Add a datastore_rw_resource_url_types helper that lists url_type values that may be edited without passing force=True
Improve error message when force=True is required but not passed.
Features: