Skip to content

[#6793] allow _id for datastore_upsert #6933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 1, 2022
Merged

[#6793] allow _id for datastore_upsert #6933

merged 6 commits into from
Aug 1, 2022

Conversation

wardi
Copy link
Contributor

@wardi wardi commented Jun 23, 2022 •
edited
Loading

Fixes #6793

Proposed fixes:

modify datastore_upsert "update" and "upsert" methods to accept _id in addition to user-defined primary key fields

Features:

  • includes tests covering changes
  • includes updated documentation
  • includes user-visible changes
  • includes API changes
  • includes bugfix for possible backport

@wardi wardi mentioned this pull request Jun 23, 2022
Closed
5 tasks
@smotornyuk smotornyuk merged commit 75ebc44 into master Aug 1, 2022
@smotornyuk smotornyuk deleted the 6793-upsert-id-pk branch August 1, 2022 11:24
@wardi wardi mentioned this pull request Oct 30, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@smotornyuk smotornyuk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Datastore upsert update not working with index _id
2 participants
@wardi @smotornyuk