Skip to content

Add test case to ensure child images can be built #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 2, 2024
Merged

Add test case to ensure child images can be built #95

merged 1 commit into from
Dec 2, 2024

Conversation

amercader
Copy link
Member

To capture issues like ckan/ckan-docker#192

@amercader amercader mentioned this pull request Nov 28, 2024
Closed
@duttonw
Copy link
Contributor

duttonw commented Nov 28, 2024

with the commit on #94 this test case now passes.

see: https://github.com/ckan/ckan-docker-base/compare/main...duttonw:ckan-docker-base:fix_onbuild_bug?expand=1 see actions against here: duttonw@9092b94

All checks have passed
6 successful checks

Build and test CKAN 2.10 images (alpine) / call-reusable-workflow / build_and_test (push) Successful in 4m
Details

Build and test CKAN 2.10 images (python) / call-reusable-workflow / build_and_test (push) Successful in 3m
Details

Build and test CKAN 2.11 images / call-reusable-workflow / build_and_test (push) Successful in 3m
Details

Build and test CKAN 2.9 images (alpine) / call-reusable-workflow / build_and_test (push) Successful in 6m
Details

Build and test CKAN 2.9 images (python) / call-reusable-workflow / build_and_test (push) Successful in 3m
Details

Build and test CKAN master images / call-reusable-workflow / build_and_test (push) Successful in 3m
Details

@amercader amercader mentioned this pull request Nov 29, 2024
Merged
@kowh-ai kowh-ai merged commit 9f28c5a into main Dec 2, 2024
4 of 6 checks passed
@kowh-ai kowh-ai deleted the test-child-images branch December 2, 2024 09:20
@duttonw
Copy link
Contributor

duttonw commented Dec 3, 2024

@kowh-ai , Can we get a tagged version cut with these fix's?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kowh-ai kowh-ai kowh-ai approved these changes

+1 more reviewer

@duttonw duttonw duttonw approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amercader @duttonw @kowh-ai