refactor: remove KfCluster functionality and related code #547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes all KFCluster-related functionality and command registrations from the codebase. The key changes include:
- Removing the KFCluster case from the SizeType function in utility/kubernetes.go
- Removing the KFCluster command registration from cmd/root.go
- Deleting the entire KFCluster command implementation files from the cmd/kfcluster directory
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| utility/kubernetes.go | Removed the KFCluster size-case from the SizeType function |
| cmd/root.go | Removed the KFCluster command import and registration |
| cmd/kfcluster/* | Deleted all KFCluster-related command files (create, update, list, delete, size, and the package root) |
Comments suppressed due to low confidence (3)
utility/kubernetes.go:297
- Removal of the '.kf.' case from SizeType is intentional; please confirm that downstream code does not rely on receiving a 'KfCluster' value.
case strings.Contains(size, ".kf."):
cmd/root.go:13
- The KFCluster command registration has been removed; ensure related documentation and migration guides are updated accordingly.
rootCmd.AddCommand(kfcluster.KFClusterCmd)
cmd/kfcluster/kfcluster.go:1
- The complete removal of the kfcluster package files is consistent with the refactor; please verify that any dependent tests or configuration references have also been updated or removed.
// Package kfcluster is the root command for Civo KFCluster
giornetta
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.