Routing un-authenticated api calls to nyc1 #529
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR routes un-authenticated API calls to the LON1 region by explicitly setting the client's region in the Civo API client configuration.
- Update CheckAPPName to set client.Region to "LON1"
- Update ListDefaultApps to set client.Region to "LON1"
utility/check.go
Outdated
| @@ -76,6 +76,7 @@ func GetK3sSize() ([]string, error) { | |||
| // CheckAPPName is a function to check if the app name is valid | |||
| func CheckAPPName(appName string) bool { | |||
| client, err := config.CivoAPIClient() | |||
| client.Region = "LON1" | |||
There was a problem hiding this comment.
The region is set on the client before the error is checked, which can lead to a nil pointer dereference if config.CivoAPIClient() returns an error. Please move the error check before setting client.Region.
| client.Region = "LON1" |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
No err check after creating the client?
There was a problem hiding this comment.
we are doing it, see blelow
utility/check.go
Outdated
| @@ -97,6 +98,7 @@ func CheckAPPName(appName string) bool { | |||
| // ListDefaultApps is a function to list the default apps in the marketplace | |||
| func ListDefaultApps() ([]string, error) { | |||
| client, err := config.CivoAPIClient() | |||
| client.Region = "LON1" | |||
There was a problem hiding this comment.
The client.Region assignment happens before the error is validated, which could cause issues if the client is nil. Consider checking the error first.
| client.Region = "LON1" |
Copilot uses AI. Check for mistakes.
No description provided.