refactor(disk_image): update DiskImage struct and related types #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the DiskImage structures and related types to update field names and add new metadata properties. Key changes include:
- Updating the DiskImage struct to include additional fields such as CreatedAt, CreatedBy, and DistributionDefault.
- Adding new fields (Source and InitialUser) to CreateDiskImageParams and updating image size fields.
- Modifying CreateDiskImageResponse to include new properties and potentially redundant image size fields.
Comments suppressed due to low confidence (2)
disk_image.go:61
- There are two fields related to image size ('DiskImageSizeBytes' and 'ImageSize') in the response struct, which may lead to confusion. Consider consolidating them into a single, consistently named field.
ImageSize int64 `json:"image_size"`
disk_image.go:30
- The JSON tag for 'DistributionDefault' is used without omitempty in DiskImage but with omitempty in CreateDiskImageResponse. Ensure consistent tag usage across structures to avoid discrepancies.
DistributionDefault bool `json:"distribution_default"`
TheRealSibasishBehera
requested changes
Apr 22, 2025
There was a problem hiding this comment.
I think there are test present in here which uses the types that are updated. So tests should be updated as well
TheRealSibasishBehera
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.