Skip to content

Change CrossVersion.full to use CrossVersion.patch for Typelevel Scala compatibility. #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 5, 2017
Merged

Change CrossVersion.full to use CrossVersion.patch for Typelevel Scala compatibility. #580

merged 2 commits into from
Mar 5, 2017

Conversation

ClydeMachine
Copy link
Contributor

Including text from the issue at typelevel/scala#135:

To use Typelevel Scala versions which are not exactly aligned with the corresponding Lightbend Scala version (ie. because they include an additional -bin-patch-nnn suffix in their version) we need to modify project builds which use CrossVersion.full (which includes the suffix) to use CrossVersion.patch (which doesn't) where appropriate (eg. for macro-paradise and other compiler plugins).

Replaced the aforementioned, as well as updating the use of "org.scala-lang" to scalaOrganization.value in library dependencies.

@codecov-io
Copy link

codecov-io commented Mar 4, 2017 •
edited
Loading

Codecov Report

Merging #580 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #580   +/-   ##
=======================================
  Coverage   82.55%   82.55%           
=======================================
  Files          73       73           
  Lines        2000     2000           
  Branches      147      147           
=======================================
  Hits         1651     1651           
  Misses        349      349
Impacted Files Coverage Δ
...re/shared/src/main/scala/io/circe/KeyDecoder.scala 43.24% <0%> (-2.71%) ❌
...rc/main/scala/io/circe/numbers/BiggerDecimal.scala 91.35% <0%> (+0.61%) ✅

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9100c32...794a790. Read the comment docs.

@travisbrown
Copy link
Member

Thanks @ClydeMachine!

@travisbrown travisbrown merged commit 1ac84f3 into circe:master Mar 5, 2017
@milessabin milessabin mentioned this pull request Mar 5, 2017
Open
35 tasks
@ClydeMachine ClydeMachine deleted the tls-compatibility branch March 6, 2017 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ClydeMachine @codecov-io @travisbrown