Hierarchical configured enum codecs in Scala 3 #2370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zarthross @hamnis please do have a look when you have a moment 🙇 |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## series/0.14.x #2370 +/- ##
=================================================
- Coverage 82.57% 82.56% -0.01%
=================================================
Files 94 94
Lines 3712 3722 +10
Branches 590 594 +4
=================================================
+ Hits 3065 3073 +8
- Misses 647 649 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zarthross
approved these changes
Apr 14, 2025
|
Thanks for reviewing and merging this! Do you think we can have a v0.14.13 with it in the near future? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi !
This is another attempt at fixing derivation of configured enum codecs with nested hierarchies for Scala 3 to have a better feature parity with Scala 2 configured codecs from
circe-generic-extras.Discovered after testing v0.14.5-RC1 of
circe-generic-extras.Previous work: #2158