Introducing "downFields" for HCursor #2367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## series/0.14.x #2367 +/- ##
=================================================
- Coverage 82.57% 82.55% -0.02%
=================================================
Files 94 94
Lines 3712 3721 +9
Branches 590 619 +29
=================================================
+ Hits 3065 3072 +7
- Misses 647 649 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zarthross
requested changes
Apr 3, 2025
Beautiful idea! Thank you! Co-authored-by: Darren Gibson <zarthross@users.noreply.github.com>
Co-authored-by: Darren Gibson <zarthross@users.noreply.github.com>
zarthross
reviewed
Apr 4, 2025
Co-authored-by: Darren Gibson <zarthross@users.noreply.github.com>
hamnis
approved these changes
Apr 7, 2025
zarthross
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
I've been a delighted user of Circe for years now. Love it!
I keep observing the pattern that I often just want to fetch a field from some deeply nested value (sometimes even with a "dynamic path"). So, I'm thinking if we could perhaps add a method next to
downField, nameddownFieldsthat would essentially achieve the following:I've attached my implementation and tests to prove it works.
Please consider it and let me know if additional discussion or work is needed.
Regards,
- Oto