Skip to content

Conversation

hamnis
Copy link
Collaborator

@hamnis hamnis commented Jul 1, 2024

  • Previously it would double escape the ~
  • Now unescapes then re-escapes the ~0 and ~1 references

I am sure this can be done in a more efficient way, but this works.

@hamnis hamnis requested a review from zarthross as a code owner July 1, 2024 14:54
@hamnis hamnis force-pushed the fix-unstable-pointer-macro branch 2 times, most recently from c0c6a11 to 578b606 Compare July 1, 2024 15:00
@hamnis hamnis changed the title Fixes the pointer literal macro pointer literal macro must not mangle already escaped pointers Jul 2, 2024
@hamnis hamnis force-pushed the fix-unstable-pointer-macro branch from 578b606 to 7821ccc Compare July 26, 2024 16:24
* Previously it would double escape the ~
* Now unescapes then re-escapes the ~0 and ~1 references
@hamnis hamnis force-pushed the fix-unstable-pointer-macro branch from 7821ccc to 3b119e7 Compare August 5, 2024 07:11
Copy link
Member

@zarthross zarthross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get a unit test for the case this is trying to fix?

@hamnis
Copy link
Collaborator Author

hamnis commented Aug 6, 2024

@zarthross test added.

@hamnis hamnis merged commit 74176b1 into circe:series/0.14.x Aug 8, 2024
18 checks passed
@hamnis hamnis deleted the fix-unstable-pointer-macro branch August 8, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flaky test PointerInterpolatorSuite io.circe.pointer.literal.PointerInterpolatorSuite seems Flaky (or there's a bug?)
2 participants