Skip to content

Update nscplugin, sbt-scala-native to 0.5.4 #2254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 25, 2024
Merged

Update nscplugin, sbt-scala-native to 0.5.4 #2254

merged 10 commits into from
Jun 25, 2024

Conversation

scala-steward
Copy link
Contributor

@scala-steward scala-steward commented Apr 17, 2024 •
edited by hamnis
Loading

About this PR

📦 Updates

from 0.4.17 to 0.5.4

📜 GitHub Release Notes - Version Diff

Usage

✅ Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

⚙ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scala-native" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scala-native" }
}]
labels: library-update, early-semver-major, semver-spec-minor, commit-count:1

@hamnis
Copy link
Collaborator

hamnis commented Apr 17, 2024

Needs sbt-typelevel release, and follow up on sbt-circe-org
then scalacheck-1.18

Do want to abandon native 0.4, since that seems like what happens elsewhere?

@scala-steward scala-steward force-pushed the update/nscplugin-0.5.1 branch 3 times, most recently from 6b3f5ef to 3f59084 Compare April 23, 2024 14:33
@kciesielski
Copy link

@hamnis fyi all the dependencies you mentioned are now released.

@hamnis
Copy link
Collaborator

hamnis commented Apr 24, 2024

We also need typelevel/discipline-munit#286

@scala-steward scala-steward force-pushed the update/nscplugin-0.5.1 branch 2 times, most recently from 70c4156 to ff74814 Compare April 27, 2024 13:44
@scala-steward scala-steward force-pushed the update/nscplugin-0.5.1 branch 2 times, most recently from 9ff3da1 to 088d39c Compare May 5, 2024 11:02
@scala-steward scala-steward force-pushed the update/nscplugin-0.5.1 branch from 088d39c to f025d2f Compare May 13, 2024 14:20
@hamnis
Copy link
Collaborator

hamnis commented May 14, 2024

also needs typelevel/cats#4585

@scala-steward scala-steward force-pushed the update/nscplugin-0.5.1 branch from f025d2f to 0777c0b Compare May 15, 2024 15:11
@hamnis hamnis mentioned this pull request May 28, 2024
Closed
@sideeffffect sideeffffect mentioned this pull request May 28, 2024
Merged
@hamnis
Copy link
Collaborator

hamnis commented May 28, 2024

We need jawn. typelevel/jawn#620

@hamnis
Copy link
Collaborator

hamnis commented May 30, 2024

needs cquiroz/scala-java-time#504

@hamnis hamnis force-pushed the update/nscplugin-0.5.1 branch from 8166267 to 5499924 Compare May 30, 2024 10:46
@hamnis hamnis mentioned this pull request Jun 1, 2024
Closed
keynmol
keynmol reviewed Jun 3, 2024
View reviewed changes
build.sbt Outdated
Comment on lines 28 to 29
val refinedVersion = "0.9.29"
val refinedNativeVersion = "0.11.1"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know the historical reason for those two being different, but hopefully the build can be simplified now that 0.11.2 is published for all the base versions needed for this PR: fthomas/refined#1274 (comment)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the reason is binary compatibility.
We need to do #2276

@sideeffffect
Copy link
Contributor

@hamnis scala-java-time 2.6.0 for Scala Native 0.5.x has been released, please update the PR 🙏
https://repo1.maven.org/maven2/io/github/cquiroz/scala-java-time_native0.5_3/2.6.0/

@hamnis hamnis mentioned this pull request Jun 7, 2024
Closed
@hamnis hamnis changed the title Update nscplugin, sbt-scala-native to 0.5.1 Update nscplugin, sbt-scala-native to 0.5.3 Jun 7, 2024
@hamnis
Copy link
Collaborator

hamnis commented Jun 7, 2024

All dependencies updated, but the native build is hanging for some reason.

@plokhotnyuk plokhotnyuk mentioned this pull request Jun 10, 2024
Merged
@durban
Copy link
Contributor

durban commented Jun 10, 2024

I think it hangs (or rather, spins) due to scala-native/scala-native/issues/3956.

@sideeffffect sideeffffect mentioned this pull request Jun 20, 2024
Merged
@JD557
Copy link
Contributor

JD557 commented Jun 24, 2024

0.5.4 was just released. It fixes scala-native/scala-native#3956, which hopefully was the last blocker.

@hamnis hamnis changed the title Update nscplugin, sbt-scala-native to 0.5.3 Update nscplugin, sbt-scala-native to 0.5.4 Jun 24, 2024
@sideeffffect
Copy link
Contributor

Why's the CI red? What's failing? Sense like many of the bulls just got cancelled...

@hamnis
Copy link
Collaborator

hamnis commented Jun 25, 2024

Why's the CI red? What's failing? Sense like many of the bulls just got cancelled...

It was failing because of a flaky pointer js-test, will have a look this morning.

hamnis
hamnis previously approved these changes Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@hamnis hamnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should now be good, @zarthross gets the final word

zarthross
zarthross previously approved these changes Jun 25, 2024
View reviewed changes
zarthross
zarthross reviewed Jun 25, 2024
View reviewed changes
@zarthross zarthross dismissed stale reviews from hamnis and themself via ec2770a June 25, 2024 14:00
@hamnis hamnis merged commit 2e435be into circe:series/0.14.x Jun 25, 2024
@sideeffffect
Copy link
Contributor

Can we have a release with this, please? 🙏

@danicheg danicheg mentioned this pull request Jul 4, 2024
Closed
@sideeffffect
Copy link
Contributor

Ping about making a new release 😸
@zarthross @hamnis @zmccoy
🙏

@hamnis
Copy link
Collaborator

hamnis commented Jul 10, 2024

This was released in 0.14.9

@sideeffffect
Copy link
Contributor

Oh, I didn't know, sorry and thank you :)
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamnis hamnis hamnis approved these changes

@zarthross zarthross zarthross approved these changes

+1 more reviewer

@keynmol keynmol keynmol left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@scala-steward @hamnis @kciesielski @sideeffffect @durban @JD557 @keynmol @zarthross