Fix srtp_unprotect_rtcp_mki when RTP auth != RTCP #733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srtp_get_session_keys, which is used by both srtp_unprotect_mki and srtp_unprotect_rtcp_mki, determines the tag len from rtp_auth. This fails when rtp_auth differ from rtcp_auth. E.g. when SRTP is used with weak authentication but SRTCP must not (RFC 3711). This commit splits the function in two: srtp_get_session_keys_rtp srtp_get_session_keys_rtcp And adds a short auth policy test to test/srtp_driver.
|
Thanks @vopatek this does seam to be an issue, I will fist fix up the CI build problem and then we can try to merge. |
pabuhler
approved these changes
Dec 11, 2024
mwalbeck
pushed a commit
to mwalbeck/docker-janus-gateway
that referenced
this pull request
Aug 17, 2025
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [cisco/libsrtp](https://github.com/cisco/libsrtp) | minor | `v2.6.0` -> `v2.7.0` | --- >⚠️ **Warning** > > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>cisco/libsrtp (cisco/libsrtp)</summary> ### [`v2.7.0`](https://github.com/cisco/libsrtp/releases/tag/v2.7.0): libSRTP 2.7.0 [Compare Source](cisco/libsrtp@v2.6.0...v2.7.0) #### What's Changed - explicitly look for mbedcrypto dependency by [@​pabuhler](https://github.com/pabuhler) in cisco/libsrtp#736 - Fix srtp\_unprotect\_rtcp\_mki when RTP auth != RTCP by [@​vopatek](https://github.com/vopatek) in cisco/libsrtp#733 - update formatting scripts to clang-format-14 by [@​pabuhler](https://github.com/pabuhler) in cisco/libsrtp#747 - update upload-artifact version in cifuzz task by [@​pabuhler](https://github.com/pabuhler) in cisco/libsrtp#748 - Fix function signature mismatch for `srtp_remove_stream` by [@​vikramdattu](https://github.com/vikramdattu) in cisco/libsrtp#746 **Full Changelog**: cisco/libsrtp@v2.6...v2.7.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4yMDUuMSIsInVwZGF0ZWRJblZlciI6IjQxLjQzLjUiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbXX0=--> Reviewed-on: https://git.walbeck.it/walbeck-it/docker-janus-gateway/pulls/170 Co-authored-by: renovate-bot <bot@walbeck.it> Co-committed-by: renovate-bot <bot@walbeck.it>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
srtp_get_session_keys, which is used by both srtp_unprotect_mki and srtp_unprotect_rtcp_mki, determines the tag len from rtp_auth.
This fails when rtp_auth differ from rtcp_auth. E.g. when SRTP is used with weak authentication but SRTCP must not (RFC 3711).
This commit splits the function in two:
srtp_get_session_keys_rtp
srtp_get_session_keys_rtcp
And adds a short auth policy test to test/srtp_driver.