Skip to content

Decoding issues for versions > 1.8.0 (Bug in CWelsDecoder::ReorderPicturesInDisplay) #3305

@akallabeth

Description

@akallabeth

Hi,

I´m using OpenH264 as H264 decoder for FreeRDP. (See FreeRDP/FreeRDP#6051)
If I am using a version > 1.8.0 the decoded stream is distorted.

Build instructions:

  1. Test on ubuntu 20.04
  2. Prepare using apt build-dep freerdp2-x11
  3. OpenH264 (meson build), mesion setup -Dprefix=/tmp/openh264-test -Dtests=disabled testbuild && ninja -C testbuild install
  4. FreeRDP cmake -DWITH_FFMPEG=OFF -DWITH_OPENH264=ON -DCMAKE_INSTALL_PREFIX=/tmp/openh264-test . && cmake --build . --target install

Run instructions:
/tmp/openh264-test/bin/xfreerdp /v:<Windows 10 RDP server IP/URL> /u:<user> /p:<password> /network:auto /gfx:avc444 /dynamic-resolution

Already at the login screen the frame data is sometimes lacking areas (black/green rectangles)
I´ve already tried using DecodeFrameNoDelay as suggested in #3079 without success.

Not exactly sure what is causing this, so maybe it is just some setting required for newer decoder versions lacking

Note:

  • It works correctly if using FFMPEG (-DWITH_FFMPEG=ON, using x264 on ubuntu) or openH264 1.8.0 builds

Screenshot with OpenH264 2.1.1:
Screenshot from 2020-07-02 10-31-13

Screenshot with OpenH264 1.8.0 (only library changed, same xfreerdp binary)
Screenshot from 2020-07-02 10-35-18

Screenshot with FFMPEG:
Screenshot from 2020-07-02 10-32-15

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions