This repository was archived by the owner on Oct 20, 2023. It is now read-only.
FIX BUG: hide/show beacon button #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
March 10, 2023 13:18
This reverts commit e0b1be1.
…ast menu backdrop
sang2925
approved these changes
Mar 13, 2023
sharplessHQ
approved these changes
Mar 15, 2023
There was a problem hiding this comment.
@arniebradfo Suggest to take care of the Dialog Cancel/Close button. For example, when trying to hide the last server/host/beacon, clicking Cancel button doesn't auto close the Hide Item popover.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix bug where clicking the "Hide {Beacon/Host/Server}" in the "..." quick meta would both hide the node and router link to the (now hidden) node. This resulted in the router pointing to an invalid route with the left panel blank. Achieved this by eating the event using
e.stopPropagation()on theQuickMetaMenu;Also fixed a Dialog console error bug.