Skip to content
This repository was archived by the owner on Oct 20, 2023. It is now read-only.

Conversation

arniebradfo
Copy link
Collaborator

🗣 Description

Consolidated Tokens into a single file and made --custom-properties for all of them. Added light theme versions of all the Tokens. Updated colors generally.

💭 Motivation and context

Some people don't like dark theme. I also just wanted to see if our color variable token system could handle this and how. It seemed to work pretty alright?

🧪 Testing

  • Look at the colors of both theme in every app. The colors for the graph still need some refinement, so don't scrutinize those too much.
  • I updated the structure of the ScrollBox component. It is now 2 components. Take a look at everywhere scrolling is implemented and make sure things still scroll appropriately

📷 Screenshots

Screen Shot 2023-01-31 at 3 48 30 PM

Screen Shot 2023-01-31 at 3 48 42 PM

Screen Shot 2023-01-31 at 3 48 47 PM

@sang2925
Copy link
Collaborator

sang2925 commented Feb 2, 2023

@arniebradfo
Cypress tests caught something. Adding command to existing comments is broken.

In develop:
Screen Shot 2023-02-02 at 9 39 34 AM

This PR:
Screen Shot 2023-02-02 at 9 43 58 AM

Copy link
Collaborator

@sang2925 sang2925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add command to existing comment is broken.

Copy link
Collaborator

@sang2925 sang2925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that add to existing comment works now!

@GoldingAustin GoldingAustin merged commit 49a8a3b into develop Feb 9, 2023
@GoldingAustin GoldingAustin deleted the light-theme branch February 9, 2023 21:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants