Skip to content
This repository was archived by the owner on Oct 20, 2023. It is now read-only.

Conversation

S4lt5
Copy link
Contributor

@S4lt5 S4lt5 commented Nov 10, 2022

πŸ—£ Description

πŸ’­ Motivation and context

πŸ§ͺ Testing

βœ… Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

βœ… Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

βœ… Post-merge checklist

  • Add a tag or create a release.

@GoldingAustin
Copy link
Collaborator

@Yablargo This looks great! Thank you so much for creating a PR!! Small request, could you remove the release:all CI test for now? We're evaluating a targeted approach to running that and we'll likely re-use the release.yml action in the future

@S4lt5
Copy link
Contributor Author

S4lt5 commented Nov 11, 2022

Sure ! I actually messed up and was intending to test this on the fork πŸ˜…I’ll fix it up Monday morning

Remove release step
Remove extra whitespace
@GoldingAustin GoldingAustin merged commit cf217c2 into cisagov:develop Nov 14, 2022
@S4lt5 S4lt5 deleted the explicit-pkg-fetch branch November 14, 2022 17:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants