This repository was archived by the owner on Oct 20, 2023. It is now read-only.
GRAPH 1: Layout improvements #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
March 28, 2023 07:44
… initializeSelection
|
When an item (beacon, host, etc.) is hidden/shown, the graph jumps around on the screen and does not stay centered. I checked the develop branch and also noticed it happening there, although it is more severe in that branch -- the graph moves completely off-screen in develop. Since the behavior isn't quite the same, not sure if you want to handle the graph movement in this branch or separately. |
GoldingAustin
approved these changes
Apr 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part 1 of a series of stacked PRs meant to isolate issues if they arise. #117
Description
Improve the graph layout so nodes are more spaced apart and less likely to overlap
forceClampToRadiusby making the forces softer. This was the primary cause of the overlap issue.initializeForcesandinitializeSelectionGraphHandler.useGraphForces()andGraphHandler.useSimpleForces(). The simple forces only include collision detection so a user can create a very precise layout.Testing
Screenshots
No screenshots since the graph 'looks' the same. It just has less error edge cases and is more fluid in interaction.