part: Shrink leaf by storing key as len+ptr #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can do the same trick in leaf as we can do in the header and store the pointer and length to the full key instead of storing the key as []byte. This will require 10 bytes (2+8) instead of the 24 bytes we'd need for the slice. According to unsafe.Sizeof leaf is now 40 bytes instead of 56. The reconciler benchmark shows the improvement nicely (~9% less): Before: 1225MB total allocated, 6011196 in-use objects, 384MB bytes in use After: 1168MB total allocated, 6011151 in-use objects, 353MB bytes in use Signed-off-by: Jussi Maki <jussi@isovalent.com>
|
dylandreimerink
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can do the same trick in leaf as we can do in the header and store the pointer and length to the full key instead of storing the key as []byte. This will require 10 bytes (2+8) instead of the 24 bytes we'd need for the slice. According to unsafe.Sizeof leaf is now 40 bytes instead of 56 (TIL: you can just do
unsafe.Sizeof(thing{})in your IDE and gopls will show "56 of constant unused"!)The reconciler benchmark shows the improvement nicely (~9% less):
Before:
After: