Skip to content

Conversation

HadrienPatte
Copy link
Member

@HadrienPatte HadrienPatte commented Jun 25, 2025

Replace gopkg.in/yaml.v3 dep with go.yaml.in/yaml/v3 which is a fork of the former maintained by the yaml org.

See cilium/cilium#39235 and yaml/go-yaml#11

The difference between gopkg.in/yaml.v3@v3.0.1 and go.yaml.in/yaml/v3@v3.0.3 are a couple of patches originally from sigs.k8s.io/yaml (yaml/go-yaml@ea54871).

(sigs.k8s.io/yaml has already moved away from their internal fork to the yaml one in kubernetes-sigs/yaml#133)

Note: tests pass, CI seems to be failing because it can't post a comment with the tests results on the PR (maybe because the PR was opened from a fork?...)

Signed-off-by: Hadrien Patte <hadrien.patte@datadoghq.com>
@HadrienPatte HadrienPatte requested a review from a team as a code owner June 25, 2025 14:24
@HadrienPatte HadrienPatte requested review from dylandreimerink and removed request for a team June 25, 2025 14:24
Copy link
Member

@dylandreimerink dylandreimerink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense given the shift of the Kubernetes project as well.

@dylandreimerink dylandreimerink merged commit c6e9b65 into cilium:main Jun 25, 2025
1 check failed
@HadrienPatte HadrienPatte deleted the pr/HadrienPatte/yaml branch June 25, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants