Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: cilium/statedb
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.4.3
Choose a base ref
...
head repository: cilium/statedb
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.4.4
Choose a head ref
  • 3 commits
  • 5 files changed
  • 2 contributors

Commits on Jun 26, 2025

  1. part: Improve Prefix() and GetWatch() tests 

    The following commits improve the 'prefixSearch' function and fix
a bug in 'GetWatch'. Extend the tests to cover more ground and
reproduce the 'GetWatch' bug.

Signed-off-by: Jussi Maki <jussi@isovalent.com>
    @joamaki
    joamaki committed Jun 26, 2025
    Configuration menu
    Copy the full SHA
    51937ff View commit details
    Browse the repository at this point in the history

  2. part: Improve prefixSearch 

    The function can be simplified and we don't need to return the root watch
channel if we've already seen matching nodes.

Signed-off-by: Jussi Maki <jussi@isovalent.com>
    @joamaki
    joamaki committed Jun 26, 2025
    Configuration menu
    Copy the full SHA
    63b8316 View commit details
    Browse the repository at this point in the history

  3. part: Fix returned watch channel in search() 

    If there was a leaf node with a key that was shorter than
our search key we incorrectly returned that leaf node's watch
channel instead of the channel of the parent non-leaf node.

This caused the watch channel returned by GetWatch() to not
close when expected.

Signed-off-by: Jussi Maki <jussi.maki@isovalent.com>
    @joamaki
    joamaki committed Jun 26, 2025
    Configuration menu
    Copy the full SHA
    32c3ea9 View commit details
    Browse the repository at this point in the history
Loading