gha: remove fragile SSH startup check #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the LVH GH action verifies the successful start of the SSH server by searching the console logoutput for the corresponding log lines. This mechanism is very fragile and leads to cases where a successful SSH server start isn't detected properly. E.g. in cases where the logoutput by qemu is interleaved. ``` [ OK ] Started 4.887573] e2scrub_all (319) used greatest stack depth: 12416 bytes left 1;39mssh.service - OpenBSD Secure Shell server. ``` Therefore, this commit removes the SSH server startup check completely. Leaving the check for a successful SSH connect to be the only check. To respect the SSH server startup time, the default wait retries for the SSH connection check gets increased from 5 to 300 (the time that we potentially waited for the SSH startup in the log check). Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
learnitall
approved these changes
May 15, 2024
kkourt
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the LVH GH action verifies the successful start of the SSH server by searching the console logoutput for the corresponding log lines.
This mechanism is very fragile and leads to cases where a successful SSH server start isn't detected properly. E.g. in cases where the logoutput by qemu is interleaved.
Therefore, this commit removes the SSH server startup check completely. Leaving the check for a successful SSH connect to be the only check.
To respect the SSH server startup time, the default wait retries for the SSH connection check gets increased from 5 to 300 (the time that we potentially waited for the SSH startup in the log check).
Fixes: cilium/cilium#32400