Skip to content

Conversation

HadrienPatte
Copy link
Member

This PR updates hadolint in the maker image from 1.17.6 to 2.12.0.

Additional changes:

  • Install the right version of hadolint based on the arch instead of always installing the amd64 one.
  • Fix FromAsCasing violations
  • Use the multi-arch version of the crane image instead of its amd64 version, see this warning:
WARNING: InvalidBaseImagePlatform
Base image gcr.io/go-containerregistry/crane:latest@sha256:5583664dfe9bb06b3e09ad612c91bd8378653d3ebec2e0b5e3d3d2c046b3b0a5 was pulled with platform "linux/amd64", expected "linux/arm64" for current build
Details of the new sha
crane manifest gcr.io/go-containerregistry/crane:latest@sha256:13952b31a107e8bc4e4c170b0097edb708cd468486a28fc20bbf0d49f71c74e1 | jq

{
  "schemaVersion": 2,
  "mediaType": "application/vnd.oci.image.index.v1+json",
  "manifests": [
    {
      "mediaType": "application/vnd.oci.image.manifest.v1+json",
      "size": 1336,
      "digest": "sha256:0c48b992c3b04231c93f59eef3ed340fc4cce8ef5cbb34ef283c5692d0ef1b4d",
      "platform": {
        "architecture": "amd64",
        "os": "linux"
      }
    },
    {
      "mediaType": "application/vnd.oci.image.manifest.v1+json",
      "size": 1336,
      "digest": "sha256:e15f1c848de7bcdf66dc66cd7a6ac1d5e757c922d85e5fe2e6f5147047dcf00a",
      "platform": {
        "architecture": "arm64",
        "os": "linux"
      }
    }
  ],
  "annotations": {
    "dev.chainguard.package.main": "",
    "org.opencontainers.image.authors": "Chainguard Team https://www.chainguard.dev/",
    "org.opencontainers.image.base.digest": "sha256:1ff7590cbc50eaaa917c34b092de0720d307f67d6d795e4f749a0b80a2e95a2c",
    "org.opencontainers.image.base.name": "cgr.dev/chainguard/static:latest",
    "org.opencontainers.image.created": "2025-03-31T16:03:48Z",
    "org.opencontainers.image.source": "https://github.com/chainguard-images/images/tree/main/images/static",
    "org.opencontainers.image.url": "https://images.chainguard.dev/directory/image/static/overview",
    "org.opencontainers.image.vendor": "Chainguard"
  }
}

@HadrienPatte HadrienPatte marked this pull request as ready for review June 23, 2025 13:47
@HadrienPatte HadrienPatte requested a review from a team as a code owner June 23, 2025 13:47
@HadrienPatte HadrienPatte requested a review from borkmann June 23, 2025 13:47
Copy link
Member

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tklauser tklauser merged commit 825582c into master Jun 24, 2025
2 checks passed
@tklauser tklauser deleted the pr/HadrienPatte/maker-image branch June 24, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants