llvm: Include llvm-strip in the image #364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvm-strip is a requirement for bpf2go, which I'm using in [1] to generate eBPF bytecode and skeletons at build time. Add llvm-strip to the llvm image so that it can be included in Cilium's builder image as well. This unblocks [1]. [1]: cilium/cilium#38693 Signed-off-by: Jordan Rife <jrife@google.com>
|
@rgo3 It looks like some of the builds timed out. Is it possible to retrigger these? |
jrife
added a commit
to jrife/cilium
that referenced
this pull request
Jul 17, 2025
llvm-strip is a requirement for bpf2go, which I'm using in [1] to generate eBPF bytecode and skeletons. As a follow up to [2], add llvm-strip to the builder image to unblock [1]. [1]: cilium#38693 [2]: cilium/image-tools#364 Signed-off-by: Jordan Rife <jrife@google.com>
jrife
added a commit
to jrife/cilium
that referenced
this pull request
Jul 17, 2025
llvm-strip is a requirement for bpf2go, which I'm using in [1] to generate eBPF bytecode and skeletons. As a follow up to [2], add llvm-strip to the builder image to unblock [1]. [1]: cilium#38693 [2]: cilium/image-tools#364 Signed-off-by: Jordan Rife <jrife@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
llvm-strip is a requirement for bpf2go, which I'm using in cilium/cilium#38693 to generate eBPF bytecode and skeletons at build time. Add llvm-strip to the llvm image so that it can be included in Cilium's builder image as well. This unblocks cilium/cilium#38693.