feat: use wrapper for grpc server not to use envoy proxy #226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c273486 to
814245c
Compare
geakstr
approved these changes
Apr 25, 2022
9bdfcaa to
1c7e0c7
Compare
geakstr
added a commit
to cilium/cilium
that referenced
this pull request
Apr 25, 2022
Previously we used envoy proxy container to convert grpc-web traffic to true grpc traffic, so ui backend accepts real grpc traffic. There is an alternative approach to use special wrapper for grpc service on backend: https://github.com/improbable-eng/grpc-web/tree/master/go/grpcweb Related code changes on hubble-ui itself was implemented in this PR: cilium/hubble-ui#226 Signed-off-by: Dmitry Kharitonov <dmitry@isovalent.com>
317761b to
d322b05
Compare
Signed-off-by: Dmitry Kharitonov <dmitry@isovalent.com>
d322b05 to
c1da6ba
Compare
82c7390 to
01505e3
Compare
geakstr
added a commit
to cilium/cilium
that referenced
this pull request
Apr 26, 2022
Previously we used envoy proxy container to convert grpc-web traffic to true grpc traffic, so ui backend accepts real grpc traffic. There is an alternative approach to use special wrapper for grpc service on backend: https://github.com/improbable-eng/grpc-web/tree/master/go/grpcweb Related code changes on hubble-ui itself was implemented in this PR: cilium/hubble-ui#226 Signed-off-by: Dmitry Kharitonov <dmitry@isovalent.com>
geakstr
added a commit
to cilium/cilium
that referenced
this pull request
Apr 27, 2022
Previously we used envoy proxy container to convert grpc-web traffic to true grpc traffic, so ui backend accepts real grpc traffic. There is an alternative approach to use special wrapper for grpc service on backend: https://github.com/improbable-eng/grpc-web/tree/master/go/grpcweb Related code changes on hubble-ui itself was implemented in this PR: cilium/hubble-ui#226 Signed-off-by: Dmitry Kharitonov <dmitry@isovalent.com>
geakstr
added a commit
to cilium/cilium
that referenced
this pull request
Apr 29, 2022
Previously we used envoy proxy container to convert grpc-web traffic to true grpc traffic, so ui backend accepts real grpc traffic. There is an alternative approach to use special wrapper for grpc service on backend: https://github.com/improbable-eng/grpc-web/tree/master/go/grpcweb Related code changes on hubble-ui itself was implemented in this PR: cilium/hubble-ui#226 Signed-off-by: Dmitry Kharitonov <dmitry@isovalent.com>
geakstr
added a commit
to cilium/cilium
that referenced
this pull request
May 31, 2022
Previously we used envoy proxy container to convert grpc-web traffic to true grpc traffic, so ui backend accepts real grpc traffic. There is an alternative approach to use special wrapper for grpc service on backend: https://github.com/improbable-eng/grpc-web/tree/master/go/grpcweb Related code changes on hubble-ui itself was implemented in this PR: cilium/hubble-ui#226 Signed-off-by: Dmitry Kharitonov <dmitry@isovalent.com>
aanm
pushed a commit
to cilium/cilium
that referenced
this pull request
May 31, 2022
Previously we used envoy proxy container to convert grpc-web traffic to true grpc traffic, so ui backend accepts real grpc traffic. There is an alternative approach to use special wrapper for grpc service on backend: https://github.com/improbable-eng/grpc-web/tree/master/go/grpcweb Related code changes on hubble-ui itself was implemented in this PR: cilium/hubble-ui#226 Signed-off-by: Dmitry Kharitonov <dmitry@isovalent.com>
joamaki
pushed a commit
to joamaki/cilium
that referenced
this pull request
Jun 8, 2022
[ upstream commit cb6c554 ] Previously we used envoy proxy container to convert grpc-web traffic to true grpc traffic, so ui backend accepts real grpc traffic. There is an alternative approach to use special wrapper for grpc service on backend: https://github.com/improbable-eng/grpc-web/tree/master/go/grpcweb Related code changes on hubble-ui itself was implemented in this PR: cilium/hubble-ui#226 Signed-off-by: Dmitry Kharitonov <dmitry@isovalent.com> Signed-off-by: Jussi Maki <jussi@isovalent.com>
joamaki
pushed a commit
to joamaki/cilium
that referenced
this pull request
Jun 8, 2022
[ upstream commit cb6c554 ] Previously we used envoy proxy container to convert grpc-web traffic to true grpc traffic, so ui backend accepts real grpc traffic. There is an alternative approach to use special wrapper for grpc service on backend: https://github.com/improbable-eng/grpc-web/tree/master/go/grpcweb Related code changes on hubble-ui itself was implemented in this PR: cilium/hubble-ui#226 Signed-off-by: Dmitry Kharitonov <dmitry@isovalent.com> Signed-off-by: Jussi Maki <jussi@isovalent.com>
joestringer
pushed a commit
to cilium/cilium
that referenced
this pull request
Jun 9, 2022
[ upstream commit cb6c554 ] Previously we used envoy proxy container to convert grpc-web traffic to true grpc traffic, so ui backend accepts real grpc traffic. There is an alternative approach to use special wrapper for grpc service on backend: https://github.com/improbable-eng/grpc-web/tree/master/go/grpcweb Related code changes on hubble-ui itself was implemented in this PR: cilium/hubble-ui#226 Signed-off-by: Dmitry Kharitonov <dmitry@isovalent.com> Signed-off-by: Jussi Maki <jussi@isovalent.com>
nebril
pushed a commit
to cilium/cilium
that referenced
this pull request
Jun 9, 2022
[ upstream commit cb6c554 ] Previously we used envoy proxy container to convert grpc-web traffic to true grpc traffic, so ui backend accepts real grpc traffic. There is an alternative approach to use special wrapper for grpc service on backend: https://github.com/improbable-eng/grpc-web/tree/master/go/grpcweb Related code changes on hubble-ui itself was implemented in this PR: cilium/hubble-ui#226 Signed-off-by: Dmitry Kharitonov <dmitry@isovalent.com> Signed-off-by: Jussi Maki <jussi@isovalent.com>
qmonnet
pushed a commit
to cilium/cilium
that referenced
this pull request
Jun 30, 2022
[ upstream commit cb6c554 ] Previously we used envoy proxy container to convert grpc-web traffic to true grpc traffic, so ui backend accepts real grpc traffic. There is an alternative approach to use special wrapper for grpc service on backend: https://github.com/improbable-eng/grpc-web/tree/master/go/grpcweb Related code changes on hubble-ui itself was implemented in this PR: cilium/hubble-ui#226 [ Backport notes: Conflict on files install/kubernetes/cilium/templates/hubble-ui/{_nginx.tpl,configmap.yaml,deployment.yaml}, these three fiels were all left out of the backport. This is because: - configmap.yaml and deployment.yaml do not exist on v1.9 - _nginx.tpl is only used in those files. ] Signed-off-by: Dmitry Kharitonov <dmitry@isovalent.com> Signed-off-by: Quentin Monnet <quentin@isovalent.com>
qmonnet
pushed a commit
to cilium/cilium
that referenced
this pull request
Jul 4, 2022
[ upstream commit cb6c554 ] Previously we used envoy proxy container to convert grpc-web traffic to true grpc traffic, so ui backend accepts real grpc traffic. There is an alternative approach to use special wrapper for grpc service on backend: https://github.com/improbable-eng/grpc-web/tree/master/go/grpcweb Related code changes on hubble-ui itself was implemented in this PR: cilium/hubble-ui#226 [ Backport notes: Conflict on files install/kubernetes/cilium/templates/hubble-ui/{configmap.yaml,deployment.yaml}. They correspond to .../templates/hubble-ui-configmap.yaml and .../templates/hubble-ui-deployment.yaml on v1.9. Also, I ran "make -C install/kubernetes" to update the relevant files. ] Signed-off-by: Dmitry Kharitonov <dmitry@isovalent.com> Signed-off-by: Quentin Monnet <quentin@isovalent.com>
qmonnet
pushed a commit
to cilium/cilium
that referenced
this pull request
Jul 6, 2022
[ upstream commit cb6c554 ] Previously we used envoy proxy container to convert grpc-web traffic to true grpc traffic, so ui backend accepts real grpc traffic. There is an alternative approach to use special wrapper for grpc service on backend: https://github.com/improbable-eng/grpc-web/tree/master/go/grpcweb Related code changes on hubble-ui itself was implemented in this PR: cilium/hubble-ui#226 [ Backport notes: Conflict on files install/kubernetes/cilium/templates/hubble-ui/{configmap.yaml,deployment.yaml}. They correspond to .../templates/hubble-ui-configmap.yaml and .../templates/hubble-ui-deployment.yaml on v1.9. Also, I ran "make -C install/kubernetes" to update the relevant files. ] Signed-off-by: Dmitry Kharitonov <dmitry@isovalent.com> Signed-off-by: Quentin Monnet <quentin@isovalent.com>
qmonnet
pushed a commit
to cilium/cilium
that referenced
this pull request
Jul 6, 2022
[ upstream commit cb6c554 ] Previously we used envoy proxy container to convert grpc-web traffic to true grpc traffic, so ui backend accepts real grpc traffic. There is an alternative approach to use special wrapper for grpc service on backend: https://github.com/improbable-eng/grpc-web/tree/master/go/grpcweb Related code changes on hubble-ui itself was implemented in this PR: cilium/hubble-ui#226 [ Backport notes: Conflict on files install/kubernetes/cilium/templates/hubble-ui/{configmap.yaml,deployment.yaml}. They correspond to .../templates/hubble-ui-configmap.yaml and .../templates/hubble-ui-deployment.yaml on v1.9. Also, I ran "make -C install/kubernetes" to update the relevant files. ] Signed-off-by: Dmitry Kharitonov <dmitry@isovalent.com> Signed-off-by: Quentin Monnet <quentin@isovalent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.