Add missing program type feature probes #890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmb
reviewed
Dec 16, 2022
9f7da81 to
ee19f4b
Compare
ee19f4b to
52a5e14
Compare
With this commit it is possible to set `btf.funcInfoMeta` on asm.Instructions from outside the `btf` package. Signed-off-by: Robin Gögge <r.goegge@isovalent.com>
Hardcode bpf_init as the fentry probe target. It's been part of the kernel since 4.4 (torvalds/linux@b2197755b263), has been completely untouched, and has a simple signature. For probing a BPF program type, it makes sense to target a symbol from the BPF subsystem. Signed-off-by: Robin Gögge <r.goegge@isovalent.com> Signed-off-by: Timo Beckers <timo@isovalent.com>
52a5e14 to
6e188e9
Compare
lmb
approved these changes
Dec 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR we support feature probes for all program types the library currently supports.