windows: even more test fixes #1709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test was added in bf5a6cd ("collection: don't copy btf.Spec in CollectionSpec.Copy()"). We now copy the spec, so the test doesn't add anything meaningful. Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
Replace the test added in 278a914 ("map: check MapReplacements compatibility after applying BPF_F_MMAPABLE") with one that doesn't rely on the ELF reader. Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
7424d92 to
84865dc
Compare
Stop relying on SkLookup for the test and instead use a SocketFilter. Simply assert that we get EINVAL from the kernel. Also remove a now unnecessary version skip, since we don't test against such old kernel versions anymore. Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
The test is a less exhaustive version of TestProgramVerifierLog, remove it. Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
84865dc to
d78cf4c
Compare
ti-mo
reviewed
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More prep work to make the Windows support easier to add.
collection: remove obsolete TestCollectionSpecLoadCopy
collection: remove TestCollectionSpecLoadMutate
collection: fix missing Map.Close in collectionLoader.loadMap
program: rework TestProgramRunEmptyData
program: remove duplicate TestProgramVerifierOutput
testutils: add missing t.Helper() calls