ci: use real staticcheck #1779
ci: use real staticcheck #1779
Conversation
7b954fb to
d2a81c5
Compare
|
@ti-mo staticcheck is kind of slow, 20s for every run. How about I drop the darwin cross build? I don't think it adds much since we now do the wasm build. |
I'm not sure if that's necessarily true. Take an old run, for example: https://github.com/cilium/ebpf/actions/runs/14728073480/job/41335459778?pr=1764. golangci-lint takes 12s there, while it takes 4s in this PR. Clearly, running staticcheck (or golangci-lint) warms up a cache somewhere. Since |
golangci-lint uses a copy of staticcheck rules, which leads to funky differences between what staticcheck reports locally and what golangci-lint reports. This is annoying, and the real staticcheck is of higher quality than golangci-lint. Use it in CI instead of the copy. Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
golangci-lint uses a copy of staticcheck rules, which leads to funky differences between what staticcheck reports locally and what golangci-lint reports. This is annoying, and the real staticcheck is of higher quality than golangci-lint. Use it in CI instead of the copy.