map: reduce false positives of BPF_F_NO_PREALLOC hint on EINVAL #1776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new MapType.mustHaveNoPrealloc() helper to collect map types that need BPF_F_NO_PREALLOC in order to be created successfully. This reduces the potential for red herrings while troubleshooting why map creation returns EINVAL. Also added a similar warning for map types that are known to require the flag when the user forgets to specify the flag. Signed-off-by: Timo Beckers <timo@isovalent.com>
dylandreimerink
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new MapType.mustHaveNoPrealloc() helper to collect map types that need BPF_F_NO_PREALLOC in order to be created successfully. This reduces the potential for red herrings while troubleshooting why map creation returns EINVAL.
Also added a similar warning for map types that are known to require the flag when the user forgets to specify the flag.
Supersedes #1720.