Skip to content

Conversation

ti-mo
Copy link
Collaborator

@ti-mo ti-mo commented Dec 19, 2024

  • Improve podman QoL by mounting the user's go module cache.
  • Reduce verbosity of gentypes
  • Reduce verbosity of bpf2go behind -debug flag or V=1 env

@ti-mo ti-mo force-pushed the tb/make-perf branch 4 times, most recently from aea4229 to ca725b9 Compare December 19, 2024 16:31
@ti-mo ti-mo changed the title ci: cache apt package installs, reduce bpf2go and gentypes verbosity ci: reduce bpf2go and gentypes verbosity, mount gomodcache when using podman Mar 25, 2025
@ti-mo ti-mo marked this pull request as ready for review March 25, 2025 09:31
@ti-mo ti-mo requested a review from a team as a code owner March 25, 2025 09:31
@lmb
Copy link
Collaborator

lmb commented Mar 26, 2025

Ack on the podman changes.

Verbose gentypes is useful because it gives context which type failed when generating, try changing one of the patches to return an error and you'll see what I mean. I think it'd be nice to keep that, outputting a number doesn't really tell me anything useful imo. When is it too verbose for you?

I'm neutral on the bpf2go change. Does the tool print anything now by default? I always ask myself whether things worked when there is no output at all.

@ti-mo
Copy link
Collaborator Author

ti-mo commented Mar 31, 2025

Verbose gentypes is useful because it gives context which type failed when generating, try changing one of the patches to return an error and you'll see what I mean.

I'll take another look and maybe add a verbose flag like bpf2go has now.

outputting a number doesn't really tell me anything useful imo

Does the tool [bpf2go] print anything now by default? I always ask myself whether things worked when there is no output at all.

I find these statements a bit contradictory. 😛 The number being non-zero means it worked and the tool did something. Over time we get a sense of how many types we'd expect to see there, and we can catch things that are out of the ordinary.

…Podman

This significantly speeds up rebuilds when running locally.

Signed-off-by: Timo Beckers <timo@isovalent.com>
ti-mo added 2 commits March 31, 2025 15:31
…ault

This made the build output relatively crowded. Only display a count from now on,
as builds are easy to troubleshoot and reproduce locally.

Run `make V=1` to show all output.

Signed-off-by: Timo Beckers <timo@isovalent.com>
The verbose flag defaults to the 'V=' environment variable used by Make,
so e.g. running `make V=1` will turn on verbosity for bpf2go builds.

Signed-off-by: Timo Beckers <timo@isovalent.com>
@ti-mo ti-mo merged commit 7b8cc32 into cilium:main Apr 2, 2025
17 checks passed
@ti-mo ti-mo deleted the tb/make-perf branch April 2, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants