map: check MapReplacements compatibility after applying BPF_F_MMAPABLE #1655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were 2 problems with the existing implementation: - cl.loadMap would mutate the original MapSpec before loading - map compatibility was checked before cl.loadMap applied the BPF_F_MMAPABLE flag To address this, the following changes were made: - MapSpec.Copy() is called in loadMap, to follow suit with cl.loadProgram - the compatibility check on MapReplacements was deferred to loadMap, after flags are mutated - Added a superficial CollectionSpec mutation test after loading, using the same logic as TestLoadCollectionSpec. testutils.IsDeepCopy() isn't usable here since MapSpec.Copy() doesn't deepcopy .Contents. - Added a regression test on using .data and .rodata in MapReplacements Signed-off-by: Timo Beckers <timo@isovalent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were 2 problems with the existing implementation:
To address this, the following changes were made:
Fixes issues seen in cilium/pwru#484. cc @brb @Asphaltt