Skip to content

Conversation

brycekahle
Copy link
Contributor

follow up to #524 with only the WakeupEvents portion.

@brycekahle brycekahle requested a review from florianl as a code owner March 28, 2024 20:47
Signed-off-by: Bryce Kahle <bryce.kahle@datadoghq.com>
@brycekahle brycekahle force-pushed the bryce.kahle/wakeup-events branch from e56a8c8 to 01282fa Compare March 28, 2024 21:03
Copy link
Contributor

@florianl florianl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 🙏
Just a minor request for an additional check in createPerfEvent.

@lmb lmb merged commit 9c1d099 into cilium:main Apr 3, 2024
@dylandreimerink
Copy link
Member

Hi! It seems this PR introduced a flaky test, see #1419. @brycekahle could you take a look? So far I have not been able to find the root cause, will update the issue if I do.

@brycekahle brycekahle deleted the bryce.kahle/wakeup-events branch April 18, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants