CFP-34577: per-service load balancing algorithm selection #56
Conversation
Signed-off-by: Aleksander Mistewicz <amistewicz@google.com>
|
cc @cilium/sig-lb |
Signed-off-by: Aleksander Mistewicz <amistewicz@google.com>
|
cc @kl52752 |
|
@kl52752 Note you can subscribe to issues and pull requests with the button on the side 👇 🙂 |
There was a problem hiding this comment.
Thanks. I've commented in the Google Doc. LGTM as sig-lb. Please base the implementation on top of cilium/cilium#35430 (cc @joamaki).
|
LGTM, commented in the Google doc as well, I presume eventually this would need to be updated. From the G doc discussion, looks like we're all on the same page. Happy to help pushing this forward! |
There was a problem hiding this comment.
It looks like the text here is not yet synced with the latest on the Google doc. When the google doc discussion is completed, please update this before we approve+merge.
I proposed some minor changes. @@kl52752 it looks like you're taking over this effort after @AwesomePatrol, is that right? Do you have access to change the branch here? If not, maybe it makes sense to reopen a fresh copy of this PR with the updates from the doc.
0a1d8b2 to
e8a9a70
Compare
Signed-off-by: Katarzyna Lach <katarzynalach@google.com>
e8a9a70 to
78af291
Compare
There was a problem hiding this comment.
I understand that the CFP is now synced to the latest comments on the doc and should be about ready to merge, is that correct?
I added some minor comments below mostly just to line the proposal up with the latest template formats, but this seems like it should be good to merge.
Co-authored-by: Joe Stringer <joestringernz@gmail.com> Signed-off-by: kl52752 <89914070+kl52752@users.noreply.github.com>
yes the proposal is synced with the doc, |
Co-authored-by: Joe Stringer <joestringernz@gmail.com> Signed-off-by: kl52752 <89914070+kl52752@users.noreply.github.com>
Discussion in Google Docs or cilium/cilium#34577