cli: Do not directly depend on DaemonConfig #39907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
47a1232 to
c83f366
Compare
|
/test |
Instead introduce a minimal version of DaemonConfig for the feature detection. The new struct is used to work around situations where we want to introduce a breaking change to DaemonConfig. CLI is required to work with all stable Cilium versions. So, the breaking change could break CLI for some versions. In any case, it is preferred to NOT do feature detection based on the runtime config, as it was never meant to provide a stable "API". Suggested-by: Sebastian Wicki <sebastian@isovalent.com> Signed-off-by: Martynas Pumputis <martynas@isovalent.com>
c83f366 to
88112b5
Compare
|
/test |
christarazi
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead introduce a minimal version of DaemonConfig for the feature detection.
The new struct is used to work around situations where we want to introduce a breaking change to DaemonConfig. CLI is required to work with all stable Cilium versions. So, the breaking change could break CLI for some versions.
In any case, it is prefered to NOT do feature detection based on the runtime config, as it was never meant to provide a stable "API".
Suggested-by: Sebastian Wicki sebastian@isovalent.com