ipsec: Extend Go tests to cover IPv6 #39978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test used to run only for IPv4-only configs. Let's make it run for dual-stack and IPv6-only clusters as well. Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
This change aims to prepare for the coverage of IPv6 addresses in a subsequent commit. We will need to change the test IPs to be IPv6 addresses instead of IPv4 addresses. That will happen via a setup function so making these into global variables helps. These tests can't run in parallel due to the XFRM states and policies so there's no risk of race condition on the global variables. Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
This change will ease the refactoring in the next commit, to allow covering both IPv4 and IPv6 addresses. These tests can't run in parallel anyway due to the XFRM states and policies, so there's no risk of race condition. Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
This commit refactors some tests in ipsec_linux_test.go to be able to cover IPv6 in a subsequent commit. Tests that will cover both IPv4 and IPv6 addresses are folded into a TestAll function. Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
b663b08 to
6312d0a
Compare
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits for details.