Skip to content

connectivity: Include detailed failure messages in test report #39866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2025

Conversation

aanm
Copy link
Member

@aanm aanm commented Jun 3, 2025

Include the reason why a test action failed (e.g., "Pod flow was interrupted") in the final connectivity test report. This makes it easier to diagnose test failures by showing error messages like "flow was interrupted (restart count does not match 0 != 1)" directly in the report summary, rather than requiring users to search through detailed test logs.

Example: https://github.com/cilium/cilium/actions/runs/15419346198/job/43390381268

Before
image

After
image

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 3, 2025
@aanm
Copy link
Member Author

aanm commented Jun 3, 2025

/test

@github-actions github-actions bot added cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary labels Jun 3, 2025
@aanm aanm force-pushed the pr/test-print-error-message-in-report branch 2 times, most recently from 9dffe27 to 7d9c7e0 Compare June 3, 2025 15:43
@aanm
Copy link
Member Author

aanm commented Jun 3, 2025

/test

@aanm aanm force-pushed the pr/test-print-error-message-in-report branch from 7d9c7e0 to 27a2961 Compare June 3, 2025 17:01
@aanm
Copy link
Member Author

aanm commented Jun 3, 2025

/test

@aanm aanm force-pushed the pr/test-print-error-message-in-report branch 2 times, most recently from 41b4de2 to 2a8990c Compare June 3, 2025 18:21
@aanm aanm added release-note/ci This PR makes changes to the CI. and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Jun 3, 2025
Include the reason why a test action failed (e.g., "Pod flow was interrupted")
in the final connectivity test report. This makes it easier to diagnose test
failures by showing error messages like "flow was interrupted (restart count
does not match 0 != 1)" directly in the report summary, rather than requiring
users to search through detailed test logs.

Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm force-pushed the pr/test-print-error-message-in-report branch from 2a8990c to e6e6bf5 Compare June 3, 2025 18:24
@aanm
Copy link
Member Author

aanm commented Jun 3, 2025

/test

@aanm aanm marked this pull request as ready for review June 3, 2025 18:24
@aanm aanm requested a review from a team as a code owner June 3, 2025 18:24
@aanm aanm requested a review from viktor-kurchenko June 3, 2025 18:24
@aanm aanm enabled auto-merge June 3, 2025 18:24
@aanm aanm added this pull request to the merge queue Jun 4, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 4, 2025
@aanm aanm added this pull request to the merge queue Jun 4, 2025
Merged via the queue into main with commit e9042c3 Jun 4, 2025
137 of 169 checks passed
@aanm aanm deleted the pr/test-print-error-message-in-report branch June 4, 2025 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants