build: fix image dir on make image tag script #39722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the usage of the hardcoded image directory by using the image_dir parameter instead. Signed-off-by: Antony Reynaud <antony.reynaud@isovalent.com>
b0b7dfa to
4d53cfb
Compare
rolinh
approved these changes
May 27, 2025
|
@Artyop Does this fix need to be backported? |
Not really, hardcoded value was the correct one anyway so I'm not sure backporting it would be useful |
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the usage of the hardcoded image directory by using the image_dir parameter instead.