helm: KPR subflag changes #39721
Merged
helm: KPR subflag changes #39721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
squeed
approved these changes
May 26, 2025
tommyp1ckles
approved these changes
May 27, 2025
The commit f5f831f ("cilium, helm: Fix hostPort and externalIPs") removed the individual setting of each flag when --kpr=false: If KPR is false, setting these to true does not make any sense. Thus, remove this to avoid confusion. However, it kept "partial", which is removed since v1.14 [1] (EOL). Remove the options entirely. [1]: #26036 Signed-off-by: Martynas Pumputis <martynas@isovalent.com>
It was removed in v1.14 [1] (EOL) [1]: #26036 Signed-off-by: Martynas Pumputis <martynas@isovalent.com>
The "disabled" value is deprecated since v1.14 (EOL). Change the check to == "true" to make the assignment effective. Signed-off-by: Martynas Pumputis <martynas@isovalent.com>
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit msgs.