-
Notifications
You must be signed in to change notification settings - Fork 3.4k
cli: require Cilium v1.14 #39717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
cli: require Cilium v1.14 #39717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/test |
c46b468
to
b41e544
Compare
/ci-integration |
b41e544
to
ba91b56
Compare
/ci-integration |
viktor-kurchenko
approved these changes
May 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of NITs but LGTM!
ysksuzuki
approved these changes
May 26, 2025
squeed
reviewed
May 26, 2025
squeed
approved these changes
May 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nit, but looks good.
We currently claim compatibility for Cilium v1.15 or newer. But as the Cilium CI still downgrades into v1.14, let's keep the v1.14-specific handling around for a bit longer. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
ba91b56
to
0978b44
Compare
/test |
auto-merge was automatically disabled
May 26, 2025 18:00
Pull Request is not mergeable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cilium-cli
This PR contains changes related with cilium-cli
cilium-cli-exclusive
This PR only impacts cilium-cli binary
release-note/misc
This PR makes changes that have no direct user impact.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently claim compatibility for Cilium v1.15 or newer. But as the Cilium CI still downgrades into v1.14, let's keep the v1.14-specific handling around for a bit longer.