Skip to content

cli: require Cilium v1.14 #39717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2025
Merged

cli: require Cilium v1.14 #39717

merged 1 commit into from
May 26, 2025

Conversation

julianwiedmann
Copy link
Member

We currently claim compatibility for Cilium v1.15 or newer. But as the Cilium CI still downgrades into v1.14, let's keep the v1.14-specific handling around for a bit longer.

@julianwiedmann julianwiedmann added the release-note/misc This PR makes changes that have no direct user impact. label May 26, 2025
@julianwiedmann julianwiedmann requested a review from a team as a code owner May 26, 2025 05:48
@julianwiedmann julianwiedmann added the cilium-cli This PR contains changes related with cilium-cli label May 26, 2025
@julianwiedmann julianwiedmann requested review from a team as code owners May 26, 2025 05:48
@julianwiedmann julianwiedmann added the cilium-cli-exclusive This PR only impacts cilium-cli binary label May 26, 2025
@julianwiedmann julianwiedmann requested review from a team as code owners May 26, 2025 05:48
@julianwiedmann
Copy link
Member Author

/test

@julianwiedmann julianwiedmann enabled auto-merge May 26, 2025 05:54
@julianwiedmann julianwiedmann force-pushed the pr/jwi/main/cli-cleanup branch from c46b468 to b41e544 Compare May 26, 2025 06:42
@julianwiedmann
Copy link
Member Author

/ci-integration

@julianwiedmann julianwiedmann force-pushed the pr/jwi/main/cli-cleanup branch from b41e544 to ba91b56 Compare May 26, 2025 06:59
@julianwiedmann
Copy link
Member Author

/ci-integration

Copy link
Contributor

@viktor-kurchenko viktor-kurchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of NITs but LGTM!

Copy link
Contributor

@squeed squeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit, but looks good.

We currently claim compatibility for Cilium v1.15 or newer. But as the
Cilium CI still downgrades into v1.14, let's keep the v1.14-specific
handling around for a bit longer.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann julianwiedmann force-pushed the pr/jwi/main/cli-cleanup branch from ba91b56 to 0978b44 Compare May 26, 2025 16:30
@julianwiedmann
Copy link
Member Author

/test

@julianwiedmann julianwiedmann added this pull request to the merge queue May 26, 2025
auto-merge was automatically disabled May 26, 2025 18:00

Pull Request is not mergeable

Merged via the queue into main with commit 489859b May 26, 2025
267 of 274 checks passed
@julianwiedmann julianwiedmann deleted the pr/jwi/main/cli-cleanup branch May 26, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants