Skip to content

clustermesh: deprecate kvstoremesh.enabled helm option #39785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

marseel
Copy link
Contributor

@marseel marseel commented May 29, 2025

KVStoreMesh has been enabled by default starting from v1.16. Let's deprecate option that allows for disabling KVStoreMesh starting from 1.18 and remove it in 1.19.

cc @cilium/sig-clustermesh

clustermesh: helm option that allows for disabling KVStoreMesh has been deprecated

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 29, 2025
@marseel marseel added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label May 29, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 29, 2025
@marseel
Copy link
Contributor Author

marseel commented May 29, 2025

/test

@marseel marseel force-pushed the pr/marseel/deprecate_kvstoremesh_helm branch from 3637279 to a289f40 Compare May 29, 2025 12:02
Copy link
Member

@giorio94 giorio94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@marseel marseel force-pushed the pr/marseel/deprecate_kvstoremesh_helm branch from a289f40 to bab9898 Compare May 29, 2025 12:16
KVStoreMesh has been enabled by default starting from v1.16.
Let's deprecate option that allows for disabling KVStoreMesh starting
from 1.18 and remove it in 1.19.

Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
@marseel marseel force-pushed the pr/marseel/deprecate_kvstoremesh_helm branch from bab9898 to f9d5f6a Compare May 29, 2025 12:27
@marseel marseel requested a review from giorio94 May 29, 2025 12:44
@marseel marseel marked this pull request as ready for review May 29, 2025 12:44
@marseel marseel requested review from a team as code owners May 29, 2025 12:44
@marseel
Copy link
Contributor Author

marseel commented May 29, 2025

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 2, 2025
@joestringer joestringer added this pull request to the merge queue Jun 2, 2025
Merged via the queue into cilium:main with commit 9a390ab Jun 2, 2025
80 of 81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants