bpf: egressgw: modernize the FIB-driven redirect path #39781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now strictly require that the underlying kernel supports bpf_redirect_neigh(). As this function is only called from TC context (and therefore has access to this helper), we can now remove the fallback paths. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
When called by from-overlay, the helper now returns either an error or CTX_ACT_REDIRECT. There's no more fallthrough to the host networking path with CTX_ACT_OK. Remove the code that supported this fallthrough path. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
|
/test |
YutaroHayakawa
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we can require that the neigh-resolver is available in this code path (since the
egress_gw_fib_lookup_and_redirect()helper is only called from TC context), there's potential to remove some unused fallback code & handling in bpf_overlay.