policy: extract namespace only once on repository insert/delete #39771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The (*rule).key.resource.Namespace method used to get the namespace for accessing (*Repository).rulesByNamespace implies strings.Cut on the ResourceID for each call. Cache the namespace value to improve repository insert/delete time a bit by avoiding these repeated strings.Cut calls. Signed-off-by: Tobias Klauser <tobias@cilium.io>
|
/test |
doniacld
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
(*rule).key.resource.Namespacemethod used to get the namespace for accessing(*Repository).rulesByNamespaceimpliesstrings.Cuton theResourceIDfor each call.Cache the namespace value to improve repository insert/delete time a bit by avoiding these repeated
strings.Cutcalls.