Fix agent graceful shutdown #39762
Merged
Fix agent graceful shutdown #39762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tklauser
approved these changes
May 28, 2025
|
/test |
joamaki
approved these changes
May 28, 2025
joamaki
reviewed
May 28, 2025
When the healthz job has its context closed, we should be closing the server. Otherwise, the healthz server lingers as the agent is trying to close. Signed-off-by: Casey Callendrello <cdc@isovalent.com>
When shutting down the agent, sometimes the number of nodes is zero. This causes a divide-by-zero panic. Signed-off-by: Casey Callendrello <cdc@isovalent.com>
The iptables reconciler was waiting for the manager to close all channes, but Hive won't shut down the manager until the reconciler has stopped. So, reorder how they're added to the lifecycle. Signed-off-by: Casey Callendrello <cdc@isovalent.com>
As the agent shut down, this controller was stuck, retrying over and over, as regeneration was failing. We can detect this case and return a special error to indicate the controller is done. Signed-off-by: Casey Callendrello <cdc@isovalent.com>
sayboras
approved these changes
May 28, 2025
ldelossa
approved these changes
May 28, 2025
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I was working on some other shutdown code, I noticed that the agent no longer gracefully shuts down. This was due to a few hung shutdown processes.
Please review by commit. The fixes were minor.