workflows: Remove kvstore related configs in conformance-multi-pool #39754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multi-Pool IPAM does not officially support KVStore yet, therefore we should not generate KVStore related configurations in conformance-multi-pool workflow. Fixes: 0598e0b ("ci/multi-pool: Generate config matrix from file") Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
joestringer
approved these changes
May 27, 2025
I don't think we need it, it's just a removal of two additional configs that were actually the same as the two before, since we don't have support for kvstore yet. |
|
/test |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multi-Pool IPAM does not officially support KVStore yet, therefore we should not generate KVStore related configurations in conformance-multi-pool workflow.
In #39561 those configs were added inadvertently, but they are actually equal to the previous ones, since the workflow has not yet been updated to test kvstore too.
Fixes: 0598e0b ("ci/multi-pool: Generate config matrix from file")
Related: #39561