Skip to content

logging: Update klog matching regexp #39748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2025
Merged

logging: Update klog matching regexp #39748

merged 1 commit into from
May 29, 2025

Conversation

HadrienPatte
Copy link
Member

client-go has been updated and no longer has the typo that required this fix.

See

cilium/vendor/k8s.io/client-go/tools/leaderelection/leaderelection.go

Line 429 in 40c6f00

klog.Errorf("Failed to update lock optimistically: %v, falling back to slow path", err)

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!
logging: Update klog matching regexp

@HadrienPatte
logging: Update klog matching regexp
828dbf2 
client-go has been updated and no longer has the typo that required this
fix.

Signed-off-by: Hadrien Patte <hadrien.patte@datadoghq.com>
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 27, 2025
@HadrienPatte
Copy link
Member Author

/test

@HadrienPatte HadrienPatte marked this pull request as ready for review May 27, 2025 15:25
@HadrienPatte HadrienPatte requested a review from a team as a code owner May 27, 2025 15:25
@HadrienPatte HadrienPatte requested a review from asauber May 27, 2025 15:25
@aanm aanm enabled auto-merge May 29, 2025 11:13
@aanm aanm added area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. release-note/misc This PR makes changes that have no direct user impact. labels May 29, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 29, 2025
@aanm aanm added this pull request to the merge queue May 29, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 29, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 29, 2025
@aditighag aditighag added this pull request to the merge queue May 29, 2025
Merged via the queue into cilium:main with commit a9887e0 May 29, 2025
73 checks passed
@HadrienPatte HadrienPatte deleted the optimistically branch May 30, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asauber asauber asauber approved these changes

Assignees
No one assigned
Labels
area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HadrienPatte @asauber @aanm @aditighag