Skip to content

loadbalancer: Add LoadBalancerClass to Service #39745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2025

Conversation

joamaki
Copy link
Contributor

@joamaki joamaki commented May 27, 2025

The LoadBalancerClass is used by pkg/bgpv1 and by pkg/l2announcer. Add it so we can in the future flip them to using Table[*lb.Service] instead of Resource[*corev1.Service].

The LoadBalancerClass is used by pkg/bgpv1 and by pkg/l2announcer.
Add it so we can in the future flip them to using Table[*lb.Service]
instead of Resource[*corev1.Service].

Signed-off-by: Jussi Maki <jussi@isovalent.com>
@joamaki joamaki requested a review from brb May 27, 2025 12:49
@joamaki joamaki requested a review from a team as a code owner May 27, 2025 12:49
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 27, 2025
@joamaki joamaki added the release-note/misc This PR makes changes that have no direct user impact. label May 27, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 27, 2025
@joamaki
Copy link
Contributor Author

joamaki commented May 27, 2025

/test

@joamaki joamaki enabled auto-merge May 27, 2025 14:06
Copy link
Member

@brb brb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL spec.loadBalancerClass

@joamaki
Copy link
Contributor Author

joamaki commented May 29, 2025

/test

@joamaki joamaki added this pull request to the merge queue May 29, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 29, 2025
Merged via the queue into cilium:main with commit 2fef01b May 29, 2025
73 of 74 checks passed
@joamaki joamaki deleted the pr/joamaki/lb-loadbalancer-class branch May 29, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants