Skip to content

cilium: Remove enableRuntimeDeviceDetection option #39633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 27, 2025
Merged

cilium: Remove enableRuntimeDeviceDetection option #39633

merged 1 commit into from
May 27, 2025

Conversation

joamaki
Copy link
Contributor

@joamaki joamaki commented May 20, 2025

This has been a no-op and deprecated since v1.16.

The deprecated 'enableRuntimeDeviceDetection' helm option has been removed.

@joamaki joamaki requested review from a team as code owners May 20, 2025 11:58
@joamaki joamaki added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label May 20, 2025
tklauser
tklauser requested changes May 20, 2025
View reviewed changes
Copy link
Member

@tklauser tklauser left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need to remove

cilium/daemon/cmd/daemon_main.go

Lines 243 to 245 in 088f292

flags.Bool(option.EnableRuntimeDeviceDetection, true, "Enable runtime device detection and datapath reconfiguration (experimental)")
option.BindEnv(vp, option.EnableRuntimeDeviceDetection)
flags.MarkDeprecated(option.EnableRuntimeDeviceDetection, "Runtime device detection and datapath reconfiguration is now the default and only mode of operation")

Other than that LGTM.

qmonnet
qmonnet approved these changes May 20, 2025
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack for doc changes

@joamaki
cilium: Remove enableRuntimeDeviceDetection option
481f217 
This has been a no-op and deprecated since v1.16.

Signed-off-by: Jussi Maki <jussi@isovalent.com>
@joamaki joamaki force-pushed the pr/joamaki/remove-deprecated-device-detection-flag branch from 1370f3a to 481f217 Compare May 23, 2025 09:54
@joamaki
Copy link
Contributor Author

joamaki commented May 23, 2025

Also need to remove

cilium/daemon/cmd/daemon_main.go

Lines 243 to 245 in 088f292

flags.Bool(option.EnableRuntimeDeviceDetection, true, "Enable runtime device detection and datapath reconfiguration (experimental)")
option.BindEnv(vp, option.EnableRuntimeDeviceDetection)
flags.MarkDeprecated(option.EnableRuntimeDeviceDetection, "Runtime device detection and datapath reconfiguration is now the default and only mode of operation")

Other than that LGTM.

Oopsie, fixed!

@joamaki
Copy link
Contributor Author

joamaki commented May 23, 2025

/test

@joamaki joamaki enabled auto-merge May 23, 2025 10:52
@joamaki joamaki requested a review from tklauser May 23, 2025 10:52
@joamaki
Copy link
Contributor Author

joamaki commented May 26, 2025

/test

@joamaki joamaki removed the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label May 27, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 27, 2025
@joamaki joamaki added release-note/minor This PR changes functionality that users may find relevant to operating Cilium. and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels May 27, 2025
@joamaki joamaki added this pull request to the merge queue May 27, 2025
Merged via the queue into cilium:main with commit 5643479 May 27, 2025
69 checks passed
@joamaki joamaki deleted the pr/joamaki/remove-deprecated-device-detection-flag branch May 27, 2025 11:50
@maintainer-s-little-helper maintainer-s-little-helper bot added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tklauser tklauser tklauser approved these changes

@squeed squeed squeed approved these changes

@marseel marseel marseel approved these changes

@qmonnet qmonnet qmonnet approved these changes

@thorn3r thorn3r thorn3r approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@joamaki @tklauser @squeed @marseel @qmonnet @thorn3r